Minimize includes in header files to what they depend on

src/eth_plugin_internal.c

@@ -1,3 +1,4 @@
+#include <string.h>
 #include "eth_plugin_internal.h"
 
 bool erc20_plugin_available_check(void);

src/eth_plugin_internal.h

@@ -1,6 +1,8 @@
 #ifndef _ETH_PLUGIN_INTERNAL_H_
 #define _ETH_PLUGIN_INTERNAL_H_
 
+#include <stdint.h>
+#include <stdbool.h>
 #include "eth_plugin_interface.h"
 
 #define SELECTOR_SIZE    4

src/handle_swap_sign_transaction.c

@@ -1,6 +1,6 @@
-#include "handle_swap_sign_transaction.h"
-#include "usbd_core.h"
+#include "os_io_seproxyhal.h"
 #include "ux.h"
+#include "handle_swap_sign_transaction.h"
 #include "shared_context.h"
 #include "utils.h"
 
@@ -79,4 +79,4 @@ void handle_swap_sign_transaction(chain_config_t* config) {
     BLE_power(1, "Nano X");
 #endif  // HAVE_BLE
     app_main();
-}
+}

src/nft.h

@@ -1,8 +1,6 @@
 #ifndef _NFT_H_
 #define _NFT_H_
 
-#include "tokens.h"
-
 #define COLLECTION_NAME_MAX_LEN 70
 
 typedef struct nftInfo_t {

src/shared_context.h

@@ -3,13 +3,7 @@
 
 #include <stdbool.h>
 #include <stdint.h>
-#include <string.h>
-
-#include "os.h"
-#include "cx.h"
-#include "os_io_seproxyhal.h"
 #include "ethUstream.h"
-#include "uint256.h"
 #include "tokens.h"
 #include "chainConfig.h"
 #include "nft.h"

src_features/getEth2PublicKey/logic_getEth2PublicKey.c

@@ -1,5 +1,6 @@
 #ifdef HAVE_ETH2
 
+#include <string.h>
 #include "shared_context.h"
 
 uint32_t set_result_get_eth2_publicKey() {
@@ -9,4 +10,4 @@ uint32_t set_result_get_eth2_publicKey() {
     return tx;
 }
 
-#endif
+#endif  // HAVE_ETH2

src_features/getPublicKey/logic_getPublicKey.c

@@ -1,3 +1,4 @@
+#include <string.h>
 #include "shared_context.h"
 
 uint32_t set_result_get_publicKey() {

src_features/signMessage/ui_common_signMessage.c

@@ -1,3 +1,4 @@
+#include "os_io_seproxyhal.h"
 #include "shared_context.h"
 #include "ui_callbacks.h"
 

src_features/signMessageEIP712/ui_common_signMessage712.c

@@ -1,3 +1,4 @@
+#include "os_io_seproxyhal.h"
 #include "shared_context.h"
 #include "ui_callbacks.h"
 

src_features/signTx/ui_common_signTx.c

@@ -1,3 +1,4 @@
+#include "os_io_seproxyhal.h"
 #include "shared_context.h"
 #include "utils.h"
 #include "ui_callbacks.h"

src_features/stark_getPublicKey/logic_stark_getPublicKey.c

@@ -1,5 +1,6 @@
 #ifdef HAVE_STARKWARE
 
+#include <string.h>
 #include "shared_context.h"
 #include "feature_stark_getPublicKey.h"
 
@@ -10,4 +11,4 @@ uint32_t set_result_get_stark_publicKey() {
     return tx;
 }
 
-#endif
+#endif  // HAVE_STARKWARE

src_features/stark_sign/ui_common_stark_sign.c

@@ -1,5 +1,6 @@
 #ifdef HAVE_STARKWARE
 
+#include "os_io_seproxyhal.h"
 #include "shared_context.h"
 #include "stark_utils.h"
 #include "ui_callbacks.h"
@@ -32,4 +33,4 @@ unsigned int io_seproxyhal_touch_stark_ok(__attribute__((unused)) const bagl_ele
     return 0;  // do not redraw the widget
 }
 
-#endif
+#endif  // HAVE_STARKWARE

src_features/stark_unsafe_sign/ui_common_stark_unsafe_sign.c

@@ -1,5 +1,6 @@
 #ifdef HAVE_STARKWARE
 
+#include "os_io_seproxyhal.h"
 #include "shared_context.h"
 #include "stark_utils.h"
 #include "ui_callbacks.h"
@@ -38,4 +39,4 @@ unsigned int io_seproxyhal_touch_stark_unsafe_sign_ok(__attribute__((unused))
     return 0;  // do not redraw the widget
 }
 
-#endif
+#endif  // HAVE_STARKWARE

src_plugins/erc1155/erc1155_plugin.c

@@ -1,7 +1,9 @@
 #ifdef HAVE_NFT_SUPPORT
 
+#include <string.h>
 #include "erc1155_plugin.h"
 #include "eth_plugin_internal.h"
+#include "ethUtils.h"
 
 static const uint8_t ERC1155_APPROVE_FOR_ALL_SELECTOR[SELECTOR_SIZE] = {0xa2, 0x2c, 0xb4, 0x65};
 static const uint8_t ERC1155_SAFE_TRANSFER_SELECTOR[SELECTOR_SIZE] = {0xf2, 0x42, 0x43, 0x2a};

src_plugins/erc1155/erc1155_plugin.h

@@ -3,12 +3,11 @@
 
 #ifdef HAVE_NFT_SUPPORT
 
-#include <string.h>
-#include "eth_plugin_handler.h"
-#include "shared_context.h"
-#include "ethUtils.h"
-#include "utils.h"
+#include <stdbool.h>
+#include <stdint.h>
+#include "ethUstream.h"
 #include "uint256.h"
+#include "nft.h"
 
 // Internal plugin for EIP 1155: https://eips.ethereum.org/EIPS/eip-1155
 

src_plugins/erc1155/erc1155_provide_parameters.c

@@ -1,7 +1,10 @@
 #ifdef HAVE_NFT_SUPPORT
 
+#include <string.h>
 #include "erc1155_plugin.h"
 #include "eth_plugin_internal.h"
+#include "utils.h"
+#include "ethUtils.h"
 
 static void handle_safe_transfer(ethPluginProvideParameter_t *msg, erc1155_context_t *context) {
     uint8_t new_value[INT256_LENGTH];

src_plugins/erc1155/erc1155_ui.c

@@ -1,6 +1,10 @@
 #ifdef HAVE_NFT_SUPPORT
 
+#include <string.h>
 #include "erc1155_plugin.h"
+#include "eth_plugin_interface.h"
+#include "ethUtils.h"
+#include "utils.h"
 
 static void set_approval_for_all_ui(ethQueryContractUI_t *msg, erc1155_context_t *context) {
     switch (msg->screenIndex) {

src_plugins/erc721/erc721_plugin.c

@@ -1,7 +1,10 @@
 #ifdef HAVE_NFT_SUPPORT
 
+#include <string.h>
 #include "erc721_plugin.h"
 #include "eth_plugin_internal.h"
+#include "eth_plugin_interface.h"
+#include "ethUtils.h"
 
 static const uint8_t ERC721_APPROVE_SELECTOR[SELECTOR_SIZE] = {0x09, 0x5e, 0xa7, 0xb3};
 static const uint8_t ERC721_APPROVE_FOR_ALL_SELECTOR[SELECTOR_SIZE] = {0xa2, 0x2c, 0xb4, 0x65};

src_plugins/erc721/erc721_plugin.h

@@ -3,11 +3,10 @@
 
 #ifdef HAVE_NFT_SUPPORT
 
-#include <string.h>
-#include "eth_plugin_handler.h"
-#include "shared_context.h"
-#include "ethUtils.h"
-#include "utils.h"
+#include <stdbool.h>
+#include <stdint.h>
+#include "ethUstream.h"
+#include "nft.h"
 
 // Internal plugin for EIP 721: https://eips.ethereum.org/EIPS/eip-721
 

src_plugins/erc721/erc721_ui.c

@@ -1,6 +1,10 @@
 #ifdef HAVE_NFT_SUPPORT
 
+#include <string.h>
 #include "erc721_plugin.h"
+#include "eth_plugin_interface.h"
+#include "ethUtils.h"
+#include "utils.h"
 
 static void set_approval_ui(ethQueryContractUI_t *msg, erc721_context_t *context) {
     switch (msg->screenIndex) {

src_plugins/starkware/starkware_plugin.c

@@ -1,4 +1,5 @@
 #include <string.h>
+#include "os_io_seproxyhal.h"
 #include "eth_plugin_interface.h"
 #include "shared_context.h"       // TODO : rewrite as independant code
 #include "eth_plugin_internal.h"  // TODO : rewrite as independant code