audit fix01

2020-12-07 16:31:58 +08:00
parent 1ff3f0daf6
commit 7bc6f3e87b
4 changed files with 16 additions and 8 deletions
--- a/contracts/DODOVendingMachine/impl/DVMFunding.sol
+++ b/contracts/DODOVendingMachine/impl/DVMFunding.sol
@@ -92,6 +92,8 @@ contract DVMFunding is DVMVault {
        _burn(msg.sender, shareAmount);
        _transferBaseOut(to, baseAmount);
        _transferQuoteOut(to, quoteAmount);
+        _sync();
+        
        if (data.length > 0) {
            IDODOCallee(to).DVMSellShareCall(
                msg.sender,
@@ -101,7 +103,7 @@ contract DVMFunding is DVMVault {
                data
            );
        }
-        _sync();
+        
        emit SellShares(msg.sender, to, shareAmount, _SHARES_[msg.sender]);
    }
 }