d-bis/app-ethereum
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove check for v length

Browse Source
This commit is contained in:
pscott
2021-08-06 15:20:58 +02:00
parent e2e567ed60
commit c5fb10dd47
6 changed files with 19 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src_features/signTx/logic_signTx.c
View File

@@ -261,11 +261,10 @@ uint32_t get_chainID() {
uint32_t chain_id = 0;
if (txContext.txType == LEGACY) {
chain_id = u32_from_BE(txContext.content->v, txContext.content->vLength, true);
chain_id = u32_from_BE(txContext.content->v, txContext.content->vLength);
} else if (txContext.txType == EIP2930 || txContext.txType == EIP1559) {
chain_id = u32_from_BE(tmpContent.txContent.chainID.value,
tmpContent.txContent.chainID.length,
true);
chain_id =
u32_from_BE(tmpContent.txContent.chainID.value, tmpContent.txContent.chainID.length);
} else {
PRINTF("Txtype `%u` not supported while generating chainID\n", txContext.txType);
}

4
src_features/signTx/ui_common_signTx.c
View File

@@ -7,7 +7,7 @@ unsigned int io_seproxyhal_touch_tx_ok(__attribute__((unused)) const bagl_elemen
uint8_t signature[100];
cx_ecfp_private_key_t privateKey;
uint32_t tx = 0;
uint32_t v = u32_from_BE(tmpContent.txContent.v, tmpContent.txContent.vLength, true);
uint32_t v = u32_from_BE(tmpContent.txContent.v, tmpContent.txContent.vLength);
io_seproxyhal_io_heartbeat();
os_perso_derive_node_bip32(CX_CURVE_256K1,
tmpCtx.transactionContext.bip32Path,
@@ -27,6 +27,8 @@ unsigned int io_seproxyhal_touch_tx_ok(__attribute__((unused)) const bagl_elemen
sizeof(signature),
&info);
explicit_bzero(&privateKey, sizeof(privateKey));
PRINTF("v: %.*H\n", tmpContent.txContent.vLength, tmpContent.txContent.v);
PRINTF("u32 v: %.*H\n", sizeof(v), &v);
if (txContext.txType == EIP1559 || txContext.txType == EIP2930) {
if (info & CX_ECCINFO_PARITY_ODD) {
G_io_apdu_buffer[0] = 1;