Use uint64_t for chainID

src_features/signTx/logic_signTx.c

@@ -257,20 +257,40 @@ void prepareFeeDisplay() {
                        sizeof(strings.common.maxFee));
 }
 
+static void u64_to_string(uint64_t src, char *dst, uint8_t dst_size) {
+    // Copy the numbers in ASCII format.
+    uint8_t i = 0;
+    do {
+        // Checking `i + 1` to make sure we have enough space for '\0'.
+        if (i + 1 >= dst_size) {
+            THROW(0x6502);
+        }
+        dst[i] = src % 10 + '0';
+        src /= 10;
+        i++;
+    } while (src);
+
+    // Null terminate string
+    dst[i] = '\0';
+
+    // Revert the string
+    i--;
+    uint8_t j = 0;
+    while (j < i) {
+        char tmp = dst[i];
+        dst[i] = dst[j];
+        dst[j] = tmp;
+        i--;
+        j++;
+    }
+}
+
 void prepareNetworkDisplay() {
     char *name = get_network_name();
     if (name == NULL) {
         // No network name found so simply copy the chain ID as the network name.
-        uint32_t chain_id = get_chain_id();
-        uint8_t res = snprintf(strings.common.network_name,
-                               sizeof(strings.common.network_name),
-                               "%d",
-                               chain_id);
-        if (res >= sizeof(strings.common.network_name)) {
-            // If the return value is higher or equal to the size passed in as parameter, then
-            // the output was truncated. Return the appropriate error code.
-            THROW(0x6502);
-        }
+        uint64_t chain_id = get_chain_id();
+        u64_to_string(chain_id, strings.common.network_name, sizeof(strings.common.network_name));
     } else {
         // Network name found, simply copy it.
         strlcpy(strings.common.network_name, name, sizeof(strings.common.network_name));
@@ -308,7 +328,7 @@ void finalizeParsing(bool direct) {
     // Verify the chain
     if (chainConfig->chainId != ETHEREUM_MAINNET_CHAINID) {
         // TODO: Could we remove above check?
-        uint32_t id = get_chain_id();
+        uint64_t id = get_chain_id();
 
         if (chainConfig->chainId != id) {
             PRINTF("Invalid chainID %u expected %u\n", id, chainConfig->chainId);

src_features/signTx/ui_common_signTx.c

@@ -7,7 +7,6 @@ unsigned int io_seproxyhal_touch_tx_ok(__attribute__((unused)) const bagl_elemen
     uint8_t signature[100];
     cx_ecfp_private_key_t privateKey;
     uint32_t tx = 0;
-    uint32_t v = u32_from_BE(tmpContent.txContent.v, tmpContent.txContent.vLength);
     io_seproxyhal_io_heartbeat();
     os_perso_derive_node_bip32(CX_CURVE_256K1,
                                tmpCtx.transactionContext.bip32Path,
@@ -41,6 +40,7 @@ unsigned int io_seproxyhal_touch_tx_ok(__attribute__((unused)) const bagl_elemen
         } else {
             // New API
             // Note that this is wrong for a large v, but the client can always recover
+            uint64_t v = u64_from_BE(tmpContent.txContent.v, tmpContent.txContent.vLength);
             G_io_apdu_buffer[0] = (v * 2) + 35;
         }
         if (info & CX_ECCINFO_PARITY_ODD) {

src_features/signTx/ui_flow_signTx.c

@@ -222,9 +222,8 @@ void ux_approve_tx(bool fromPlugin) {
         ux_approval_tx_flow[step++] = &ux_approval_nonce_step;
     }
 
-    uint32_t chain_id = get_chain_id();
+    uint64_t chain_id = get_chain_id();
     if (chainConfig->chainId == ETHEREUM_MAINNET_CHAINID && chain_id != chainConfig->chainId) {
-        // TODO: do we need the `&&` above?
         ux_approval_tx_flow[step++] = &ux_approval_network_step;
     }