d-bis/app-ethereum
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove INDEX_MAX from withdrawal_index.h ; set limit to 2^19

Browse Source
This commit is contained in:
pscott
2021-04-22 14:57:30 +02:00
parent 18822f9462
commit 550fc86ba8
3 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src_features/setEth2WithdrawalIndex/cmd_setEth2WithdrawalIndex.c
View File

@@ -18,11 +18,6 @@ void handleSetEth2WithdrawalIndex(uint8_t p1,
THROW(0x6B00); THROW(0x6B00);
} }
eth2WithdrawalIndex = U4BE(dataBuffer, 0);
if (eth2WithdrawalIndex > INDEX_MAX) {
THROW(0x6A80); // scott throw this error code or create new one ?
}
THROW(0x9000); THROW(0x9000);
} }

2
src_features/setEth2WithdrawalIndex/withdrawal_index.h
View File

@@ -1,7 +1,5 @@
#include "stdint.h" #include "stdint.h"
#define INDEX_MAX 1337 // scott
void handleSetEth2WithdrawalIndex(uint8_t p1, void handleSetEth2WithdrawalIndex(uint8_t p1,
uint8_t p2, uint8_t p2,
uint8_t *dataBuffer, uint8_t *dataBuffer,

4
src_plugins/eth2/eth2_plugin.c
View File

@@ -6,7 +6,6 @@
#include "shared_context.h" #include "shared_context.h"
#include "ethUtils.h" #include "ethUtils.h"
#include "utils.h" #include "utils.h"
#include "withdrawal_index.h"
void getEth2PublicKey(uint32_t *bip32Path, uint8_t bip32PathLength, uint8_t *out); void getEth2PublicKey(uint32_t *bip32Path, uint8_t bip32PathLength, uint8_t *out);
@@ -24,6 +23,9 @@ void getEth2PublicKey(uint32_t *bip32Path, uint8_t bip32PathLength, uint8_t *out
#define DEPOSIT_CONTRACT_ADDRESS "0x00000000219ab540356cbb839cbe05303d7705fa" #define DEPOSIT_CONTRACT_ADDRESS "0x00000000219ab540356cbb839cbe05303d7705fa"
#define DEPOSIT_CONTRACT_LENGTH sizeof(DEPOSIT_CONTRACT_ADDRESS) #define DEPOSIT_CONTRACT_LENGTH sizeof(DEPOSIT_CONTRACT_ADDRESS)
// Highest index for withdrawal derivation path.
#define INDEX_MAX 524288 // 2 ^ 19
typedef struct eth2_deposit_parameters_t { typedef struct eth2_deposit_parameters_t {
uint8_t valid; uint8_t valid;
char deposit_address[ETH2_DEPOSIT_PUBKEY_LENGTH]; char deposit_address[ETH2_DEPOSIT_PUBKEY_LENGTH];